WIP: Add typing hint for src codes #99
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @Yanqiao4396 if you want to continue to work on this PR, that would be great! I encourage you to integrate Let's continue the conversation here! I am glad to help out with and/or review this PR as needed. Thanks! |
Add mypy library. Put mypy into lint check. Choose to ignore importing warning because the project works in virtual environment
Mypy expects to find all the dependencies. However, we are building on virtual environment, so ignore Mypy "Library stubs not installed" message
|
The Mypy is added successfully. The related changes pass!! |
gkapfham
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your Title
Add typing hint
Description
Add the typing hint for all the I/O of functions in source codes
Linked Issues
closes: #93\
Type of Change
Contributors
Reminder